Tarea de angular input y output utilizando bootstrap#35
Open
gentilcoreac wants to merge 1 commit intoutnfrrottads:masterfrom
Open
Tarea de angular input y output utilizando bootstrap#35gentilcoreac wants to merge 1 commit intoutnfrrottads:masterfrom
gentilcoreac wants to merge 1 commit intoutnfrrottads:masterfrom
Conversation
aotaduy
reviewed
Jul 15, 2020
| <app-todo-form (add)="onTodoItemCreated($event)"></app-todo-form> | ||
|
|
||
| <app-todo-list | ||
| *ngIf="list.length>0" |
Contributor
There was a problem hiding this comment.
pongamos espacios entre los operadores
| ngOnInit(): void { | ||
| } | ||
|
|
||
| CountTask(){ |
Contributor
There was a problem hiding this comment.
los metodos en ts/js van con minuscula, fijate la guia de airbnb de la catedra
| } | ||
|
|
||
| CountCompletedTask(){ | ||
| var count = 0; |
Contributor
There was a problem hiding this comment.
en ts/js moderno > es6, usemos let y constt en vez de var
| CountCompletedTask(){ | ||
| var count = 0; | ||
| for(var i = 0; i < this.list.length; ++i){ | ||
| if(this.list[i].isCompleted) |
Contributor
There was a problem hiding this comment.
para contar esto podes usar Arrayy.reduce es un metodo interesante
| export class TodoFormComponent implements OnInit { | ||
|
|
||
| @Output() add = new EventEmitter<any>(); | ||
| constructor() { } |
Contributor
There was a problem hiding this comment.
eliminemos metodos vacios antes de mandar el PR
| @@ -0,0 +1,59 @@ | |||
| <!-- | |||
| <ul class="list-group"> | |||
Contributor
There was a problem hiding this comment.
codigo comentado debe eliminarse
| // } | ||
| // deleteItem(item: TodoItem){ | ||
| // this.list.splice(item.id,1); | ||
| // } |
Contributor
There was a problem hiding this comment.
mismo, comentado y vacio => KILLL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea de angular input y output utilizando bootstrap