Fixed some errors in some MIPS assembly files#1
Open
zrmin wants to merge 4 commits into
Open
Conversation
added 4 commits
April 18, 2023 19:10
位于分支 zrmin
要提交的变更：
修改： basics.s
assemlator --> assembler
$ta --> $at
lw --> sw
(syscall( --> (syscall)
$a0 --> $v0
位于分支 zrmin
要提交的变更：
修改： jump_and_branches.s
Line64 addi $s0, $s0, 0 --> andi $s0, $s0, 0
Line109 $t0 < $1 --> $t0 < $t1
Line109 less_than --> less_than_1
Line121 print --> print_1
Line139 greater_or_equal --> not_less_than_2
Line182 Add two lines of assembly instructions under the
comment "This code will never be reached"
li $v0, 10
syscall
位于分支 zrmin
要提交的变更：
修改： arrays.s
Line37 consequtive --> consecutive
Line46 stirngs --> strings
Line53 a address (pointer) --> an address, a.k.a. a pointer
位于分支 zrmin
要提交的变更：
修改： subroutines.s
Line54 li $0, 0x1234abcd --> li $t0, 0x1234abcd
Line141 $a --> $a0
Line143 "Hi <name> --> "Hi <name>"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's one bug in jump_and_branches.s Line 64 (after I fixed, Line 69).
To initialize
$s0 = 0, should useandi $s0, $s0, 0, but notaddi $s0, $s0, 0, because the Mars initializes all registers to 0, so the instructionaddi $s0, $s0, 0do not become a bug when you run this file, but we should better useandi $s0, $s0, 0.