b2sum: report malformed status input#12622
Conversation
|
GNU testsuite comparison: |
|
I inspected the failing macOS localization job. The failure is in This PR only changes I do not see a b2sum/checksum regression to fix here. If the macOS |
|
The Validation section is useless, please don't add it in the future |
|
Agreed. I removed the For uutils PR openings I will keep the description focused on the behavior change, compatibility rationale, and linked issue. I will only mention local commands later when they are directly useful for review, for example explaining a CI discrepancy or documenting a targeted check after a requested change. |
|
@wondr-wclabs I would also appreciate you don't use a llm to reply to me... |
6119e6b to
246db35
Compare
What changed
b2sum -c --statusnow still reports the structural error when the checksum input contains no properly formatted checksum lines.The change is in the shared checksum validator: the
no properly formatted checksum lines founddiagnostic is no longer hidden byChecksumVerbose::Status. Regular checksum mismatches under--statusremain silent; only the “there was nothing valid to check” diagnostic is surfaced.Why
GNU
b2sum -c --statusreports this case because it is not a per-file mismatch result, it is an invalid checksum-list input. The previous logic treated it like other status-mode output and suppressed the diagnostic, leaving only the exit code.Fixes #12590.