cp: propagate the --attributes-only destination open error#12625
Open
leeewee wants to merge 1 commit into
Open
cp: propagate the --attributes-only destination open error#12625leeewee wants to merge 1 commit into
leeewee wants to merge 1 commit into
Conversation
`cp --attributes-only SRC DEST` aborted with a Result::unwrap panic when opening DEST failed (e.g. EACCES on an unwritable parent, or ENOTDIR on a non-directory parent). The CopyMode::AttrOnly branch of handle_copy_mode opened the destination and `.unwrap()`ed the result. Propagate the open error with the existing `'src' -> 'dest'` context via `CpError::IoErrContext`, like the other I/O sites in this function, so cp reports the error and exits 1 instead of crashing.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12624
cp --attributes-only SRC DESTaborted with aResult::unwrap()panic when opening the destination failed (e.g. EACCES on an unwritable parent, ENOTDIR on a non-directory parent): theCopyMode::AttrOnlybranch unwrapped the open result.Propagate the open error with the existing
'src' -> 'dest'context viaCpError::IoErrContext, like the other I/O sites inhandle_copy_mode, so cp reports the error and exits 1 instead of crashing. Adds a regression test.