Skip to content

kill: use safe rustix Signal constructor, fix spell-checker comment#12636

Merged
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:kill_rustix
Jun 6, 2026
Merged

kill: use safe rustix Signal constructor, fix spell-checker comment#12636
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:kill_rustix

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 5, 2026

Merging this PR will degrade performance by 3.2%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 322 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 25.2 ms 26.1 ms -3.2%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:kill_rustix (f987e3e) with main (533edad)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/pid-pipe (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 0024b1a into uutils:main Jun 6, 2026
173 of 174 checks passed
@sylvestre sylvestre deleted the kill_rustix branch June 6, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant