cp: handle --parents source ending in parent dir#12639
Open
nkgotcode wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12626.
When
cp --parents -rreceives a source path that ends in.., the parent-permission copy path can reach a root path without a file name and panic. This keeps that path on the existing error path instead, matching GNU coreutils behavior for the repro case.The regression test covers the trailing-parent-dir source and asserts the command exits with the expected directory-exists error instead of panicking or silently succeeding.
Validation:
cargo test --features cp --test tests test_cp::test_cp_parents_recursive_source_ending_in_parent_dir -- --exactcargo test --features cp --test tests test_cp::test_cp_parents_2_dir -- --exactcoreutils cp --parents -r src/sub/.. dexits 1 withcp: cannot create directory 'd/src/sub/..': File exists, leavesd/src/sub, and does not copysrc/sub/f_default/scripts/verify-no-ai-coauthor.shpassed immediately before push