fix: preserve UNC paths in pwd and readlink#12641
Open
a-rookie-of-C-language wants to merge 1 commit into
Open
fix: preserve UNC paths in pwd and readlink#12641a-rookie-of-C-language wants to merge 1 commit into
a-rookie-of-C-language wants to merge 1 commit into
Conversation
a-rookie-of-C-language
force-pushed
the
fix/windows-pwd-unc
branch
from
db24fa2 to
18ffac6
Compare
Contributor
|
@a-rookie-of-C-language your PR contains many unrelated commits. Please remove them. |
a-rookie-of-C-language
force-pushed
the
fix/windows-pwd-unc
branch
from
18ffac6 to
9ade898
Compare
a-rookie-of-C-language
force-pushed
the
fix/windows-pwd-unc
branch
from
9ade898 to
a09bc91
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pwd -Pon Windows whencanonicalize()returns a verbatim UNC path.readlink -fon Windows when canonicalization returns a verbatim UNC path.\\?\UNC\server\share\...back to\\server\share\...instead of incorrectly printingUNC\server\share\....\\?\C:\....Validation
cargo check --manifest-path deps\coreutils\Cargo.toml -p uu_pwd -p uu_readlinkcargo run --manifest-path deps\coreutils\Cargo.toml -p uu_pwd -- -Pcargo run --manifest-path deps\coreutils\Cargo.toml -p uu_readlink -- -f .