cp: harden sparse_copy against 32-bit panic and EOF hang#12649
Open
sylvestre wants to merge 1 commit into
Open
cp: harden sparse_copy against 32-bit panic and EOF hang#12649sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
Use u64 for the file size and offset instead of narrowing to usize with try_into().unwrap(), which panicked on 32-bit when the source exceeded usize::MAX. Also break the copy loop on a zero-byte read so a source that shrinks mid-copy no longer spins forever.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use u64 for the file size and offset instead of narrowing to usize with try_into().unwrap(), which panicked on 32-bit when the source exceeded usize::MAX. Also break the copy loop on a zero-byte read so a source that shrinks mid-copy no longer spins forever.
closes: #12648
and #12647