cat, tail, head:allways splice with broker pipe for throughput#12651
cat, tail, head:allways splice with broker pipe for throughput#12651oech3 wants to merge 1 commit into
Conversation
956e3d4 to
5c34767
Compare
|
GNU testsuite comparison: |
|
The more important part of this worth mentioning (as I discussed with you previously) is that an intermediate pipe is required to distinguish input from output errors. Currently cat will flag issues on the output as an error with the input, which could send users down entirely wrong rabbit holes |
|
Yes. But more refactoring is needed to fix it. So it will be fixed at different PR. |
Right, but keying on errnos like that is problematic, so the most sensible way is always to have the separated splice(), and it's a nice side affect of not being slower |
|
It is hard to actually cause it. but even we use middler pipe, the middler itself's error cannot be distinguished with in/output. |
splice without broker is slower by unknown reason (needs
pvfrom main branch)Closes #12464 Closes #12465
cc @dragutreis