date: reject absurd format-modifier widths before allocating#12652
Draft
sylvestre wants to merge 3 commits into
Draft
date: reject absurd format-modifier widths before allocating#12652sylvestre wants to merge 3 commits into
sylvestre wants to merge 3 commits into
Conversation
A field width that fits in usize but is enormous (e.g. %6666666666666D) was handed straight to String::try_reserve. On a normal system that fails gracefully, but under a sanitizer the oversized request aborts the process before try_reserve can return an error. Cap the width up front instead. Should make fuzz_date pass.
|
GNU testsuite comparison: |
xtqqczze
reviewed
Jun 5, 2026
Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field width that fits in usize but is enormous (e.g. %6666666666666D) was handed straight to String::try_reserve. On a normal system that fails gracefully, but under a sanitizer the oversized request aborts the process before try_reserve can return an error. Cap the width up front instead.
Should make fuzz_date pass and closes #12458