wasm: support for wasm32-wasip2 target#12653
Open
eduardomourar wants to merge 3 commits into
Open
Conversation
Contributor
|
But why? Is there any usecase wasip1 cannot cover? If wasip2 works on web browsers using shim, we should drop wasip1 at the same time. |
Author
|
The main reason to have WASI Preview 2 is because Preview 1 is not being further developed. In wasip1, we would never get full support for streams and socket. With wasip2, on other hand, we will have those as well as support for the WebAssembly Component Model. This documentation might help answering you: https://component-model.bytecodealliance.org/design/why-component-model.html#interoperability Should we drop wasip1? Probably not yet. There are few features that are missing in Preview2:
|
Contributor
|
Ok. But do you want to publish release binaries too? Or is |
sylvestre
reviewed
Jun 6, 2026
| // On WASI the fluent translation key may appear instead of the | ||
| // translated text, but the OS error string is still present. | ||
| cmd.stderr_contains("Is a directory"); | ||
| if cfg!(wasip2_runner) { |
sylvestre
reviewed
Jun 6, 2026
| // On WASI the fluent translation key may appear instead of the | ||
| // translated text, but the OS error string is still present. | ||
| cmd.stderr_contains("Is a directory"); | ||
| if cfg!(wasip2_runner) { |
sylvestre
reviewed
Jun 6, 2026
| .pipe_in("y\n") | ||
| .succeeds() | ||
| .stderr_only("rm: attempt removal of inaccessible directory 'dir'? "); | ||
| .stderr_only(if cfg!(wasi_runner) { |
sylvestre
reviewed
Jun 6, 2026
| new_ucmd!() | ||
| .args(&["--from=iec-i", "10M"]) | ||
| .fails_with_code(2) | ||
| .fails_with_code(if cfg!(wasip2_runner) { 1 } else { 2 }) |
sylvestre
reviewed
Jun 6, 2026
| ucmd.arg("1") | ||
| .fails() | ||
| .stderr_is("cat: 1: Too many levels of symbolic links\n"); | ||
| ucmd.arg("1").fails().stderr_is(if cfg!(wasi_runner) { |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the wasm32-wasip2 (WASI Preview 2) target, enabling coreutils to compile and run on sandboxed environments that can run WebAssembly components.
Changes
yes,uucoreandfs/displaymodules)