Skip to content

grep: cover zero-width EOF only-matching behavior #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhecker merged 2 commits into from
Jun 5, 2026
Merged

grep: cover zero-width EOF only-matching behavior #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c24ede
grep: handle zero-width matches at EOF
wondr-wclabs Jun 5, 2026
5ea3667
grep: narrow zero-width EOF PR to coverage
wondr-wclabs Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/test_grep.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,23 @@ fn only_matching() {
.succeeds()
.stdout_only("Hello\nhELLO\nHELLO\n");

// Zero-width matches do not print in -o mode, but still mark the line as
// matched. This matters for -v because matched lines must not be selected.
let (_s, mut c) = ucmd();
c.args(&["-o", "$"]).pipe_in("\n").succeeds().no_output();

let (_s, mut c) = ucmd();
c.args(&["-o", "-v", "$"])
.pipe_in("a\n\nb\n")
.fails_with_code(1)
.no_output();

let (_s, mut c) = ucmd();
c.args(&["-o", "-v", "x*"])
.pipe_in("a\n\nb\n")
.fails_with_code(1)
.no_output();

// After a match ends, ^ must not re-match at that position.
let (_s, mut c) = ucmd();
c.args(&["-o", "^hello*"])
Expand Down
Loading