Skip to content

grep: let dot match newline in null-data mode#45

Merged
lhecker merged 1 commit into
uutils:mainfrom
wondr-wclabs:codex/null-data-dot-newline
Jun 5, 2026
Merged

grep: let dot match newline in null-data mode#45
lhecker merged 1 commit into
uutils:mainfrom
wondr-wclabs:codex/null-data-dot-newline

Conversation

@wondr-wclabs
Copy link
Copy Markdown
Contributor

Closes #25.

Summary

  • enable Onig's dot-matches-newline option when --null-data is active
  • keep the change scoped to NUL-delimited records, where newline is ordinary data rather than the record separator
  • add a byte-level -z -o . regression for a record containing a\nb

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

GNU grep testsuite comparison:

Test results comparison:
  Current:   TOTAL: 128 / PASSED: 69 / FAILED: 38 / SKIPPED: 21
  Reference: TOTAL: 128 / PASSED: 70 / FAILED: 37 / SKIPPED: 21

Changes from main branch:
  TOTAL: +0
  PASSED: -1
  FAILED: +1

New test failures (1):
  - pcre-context

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 5, 2026

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 17 skipped benchmarks1


Comparing wondr-wclabs:codex/null-data-dot-newline (2f6926e) with main (d28bf76)

Open in CodSpeed

Footnotes

  1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@wondr-wclabs wondr-wclabs force-pushed the codex/null-data-dot-newline branch from 6d75303 to 2f6926e Compare June 5, 2026 08:15
Copy link
Copy Markdown
Collaborator

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lhecker lhecker merged commit d556159 into uutils:main Jun 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

. does not match a newline under --null-data like GNU

2 participants