Skip to content

Should show usage without argments #274#409

Merged
dspinellis merged 5 commits into
uutils:mainfrom
Devel08:fix-274
Jun 2, 2026
Merged

Should show usage without argments #274#409
dspinellis merged 5 commits into
uutils:mainfrom
Devel08:fix-274

Conversation

@Devel08
Copy link
Copy Markdown
Contributor

@Devel08 Devel08 commented May 3, 2026

resolves #274

@sylvestre
Copy link
Copy Markdown
Contributor

Please add a test to make sure we don't regress in the future? Thanks

@Devel08
Copy link
Copy Markdown
Contributor Author

Devel08 commented May 3, 2026

@sylvestre Done, I also changed the test_missing_script_argument test, because it inputted no arguments, thus it was expected to receive --help. It now inputs arguments only for a file, but not a script

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.18%. Comparing base (60243b4) to head (778dc83).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/sed/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   82.29%   82.18%   -0.11%     
==========================================
  Files          13       13              
  Lines        5534     5551      +17     
  Branches      310      312       +2     
==========================================
+ Hits         4554     4562       +8     
- Misses        977      986       +9     
  Partials        3        3              
Flag Coverage Δ
macos_latest 82.86% <0.00%> (-0.12%) ⬇️
ubuntu_latest 82.97% <0.00%> (-0.12%) ⬇️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Devel08
Copy link
Copy Markdown
Contributor Author

Devel08 commented May 3, 2026

I always forget the cargo fmt :/

Copy link
Copy Markdown
Collaborator

@dspinellis dspinellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor improvement and we're good to go.

Comment thread tests/by-util/test_sed.rs Outdated
@Devel08 Devel08 requested a review from dspinellis June 2, 2026 12:16
@dspinellis dspinellis merged commit 508d74f into uutils:main Jun 2, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should show usage without argments

3 participants