Skip to content

Implements v command #397#420

Open
Devel08 wants to merge 4 commits into
uutils:mainfrom
Devel08:implement-v
Open

Implements v command #397#420
Devel08 wants to merge 4 commits into
uutils:mainfrom
Devel08:implement-v

Conversation

@Devel08
Copy link
Copy Markdown
Contributor

@Devel08 Devel08 commented May 9, 2026

This pr implements the version command and resolves #397

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 13.63636% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.62%. Comparing base (cd2e3cb) to head (2330ab1).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/sed/compiler.rs 13.63% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   82.20%   81.62%   -0.59%     
==========================================
  Files          13       13              
  Lines        5542     5589      +47     
  Branches      310      315       +5     
==========================================
+ Hits         4556     4562       +6     
- Misses        983     1024      +41     
  Partials        3        3              
Flag Coverage Δ
macos_latest 82.29% <13.63%> (-0.61%) ⬇️
ubuntu_latest 82.40% <13.63%> (-0.60%) ⬇️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 1, 2026

Merging this PR will not alter performance

✅ 11 untouched benchmarks


Comparing Devel08:implement-v (2330ab1) with main (c45b2f5)

Open in CodSpeed

@dspinellis
Copy link
Copy Markdown
Collaborator

Thank you for the contribution! Please check the failed CI tasks.

@Devel08
Copy link
Copy Markdown
Contributor Author

Devel08 commented Jun 2, 2026

@dspinellis No problem! Fixed the failing CI tasks, can you approve the workflows please?

Comment thread src/sed/compiler.rs
Comment on lines +1264 to +1267
// GNU sed 4.9
const GNU_MAJOR: u8 = 4;
const GNU_MINOR: u8 = 9;
const GNU_PATCH: u8 = 0;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because most users scripts use GNU sed 4.9, the reason is described in "What it should do" in issue #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add v command (version assertion)

3 participants