fix: add version to shadow-core workspace dependencies for cargo publish - #206
Merged
Merged
Conversation
Without a version field, `cargo publish` fails for all crates that depend on shadow-core: all dependencies must have a version requirement specified when publishing. dependency `shadow-core` does not specify a version Add version = "0.2.0" to all three shadow-core dependency declarations in Cargo.toml (workspace.dependencies, [dependencies], and dev-dependencies) to allow `cargo publish` to work correctly.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes cargo publish --dry-run failures by ensuring the internal shadow-core dependency has an explicit version requirement when referenced via a local path, satisfying Cargo’s publishing validation rules.
Changes:
- Add
version = "0.2.0"toshadow-corein[workspace.dependencies]. - Add
version = "0.2.0"toshadow-corein the root crate’s[dependencies]. - Add
version = "0.2.0"toshadow-corein the root crate’s[dev-dependencies](withfeatures = ["shadow"]).
Suppressed comments (1)
Cargo.toml:209
- To avoid duplicating the
shadow-corepath/version in multiple sections, prefer inheriting from[workspace.dependencies]and only overriding the needed features here. This matches how theuu_*crates referenceshadow-coreviaworkspace = true.
shadow-core = { path = "src/shadow-core", version = "0.2.0", features = ["shadow"] }
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| clap = { workspace = true } | ||
| clap_complete = { workspace = true, optional = true } | ||
| shadow-core = { path = "src/shadow-core" } | ||
| shadow-core = { path = "src/shadow-core", version = "0.2.0" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.