Absolute Paths Support for Archives Creation#291
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 96.59% 96.80% +0.21%
==========================================
Files 9 9
Lines 941 1003 +62
Branches 24 24
==========================================
+ Hits 909 971 +62
Misses 31 31
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaladron
left a comment
There was a problem hiding this comment.
One minor change within, and otherwise the patch looks good to me.
| if allow_absolute { | ||
| return Some(path.to_path_buf()); | ||
| } | ||
| if path.is_absolute() { |
There was a problem hiding this comment.
I think if you do:
if path.is_absolute() && !allow_absolute {The current else clause will just handle this correct as it falls back to:
} else {
path.to_path_buf()
};And then doesn't double the work.
There was a problem hiding this comment.
Ah yes, good point!
Fixed!
|
Thanks for this! I've merged it. I did a last quick update of the git commit message to include more detail in case people need to find this commit later! |
Added support of
-P,--absolute-namesfor the creation of archive. Seems, that add support of absolute path for the extracting is requires changes intar-rslibrary and can be done later.Related to #213