refactor(scan)!: modernize channel and generator APIs - #152
Merged
Conversation
Replace legacy getter-based results with GeneratorResult[T] and
consolidate channel operations using generic helpers.
Improve cancellation handling, propagate live-rescan errors, prevent
stale JSONL values, and update generated mocks and tests.
BREAKING CHANGE: Rename GenericEngine to ScanEngine, change completion
channels to <-chan struct{}, replace PortGetter and IPGetter APIs with
GeneratorResult[T], and remove MergeBufferDataChan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The scan pipeline still used pre-generics abstractions, duplicated channel coordination logic,
and contained cancellation and error-propagation edge cases.
What Changed
Validation