Conversation
Add possibility to define java executable or use JAVA_HOME. Rename start and stop as they have nothing to do with k6
mcollovati
approved these changes
Apr 1, 2026
Contributor
mcollovati
left a comment
mcollovati
left a comment
There was a problem hiding this comment.
A minor potential improvement, but other than that looks good.
Also, perhaps the goalPrefix in the plugin POM file should be updated to loadtest to match the Javadocs.
.../testbench-converter-plugin/src/main/java/com/vaadin/testbench/loadtest/StartServerMojo.java
Show resolved
Hide resolved
.../testbench-converter-plugin/src/main/java/com/vaadin/testbench/loadtest/StartServerMojo.java
Show resolved
Hide resolved
validate given javaExecutable
mcollovati
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to define java
executable or use JAVA_HOME.
Rename start and stop as they
have nothing to do with k6