moriremote: restore the full pane-native terminal experience - #112
Merged
Conversation
The app-owned searchable Navigator is now the sole window/pane browser. Delete the unreachable upstream selection sheets, pixel capture/cache, picker-grid resizing, and their tests while retaining renderer-frame publication for safe presentation and scroll-state refresh.
Let the public facade directly own the terminal session and concrete screen adapter. Remove one-adapter modeling protocols, dead topology identities/refocus policies, excluded tracked-composer input, test fixtures from the production target, and tracing flows that had no producer.
Make the retained runtime the observable authority for status, topology, and metadata. Remove the unread revision counter, manual change relay, dead reconnecting state, and identity passthrough; cover direct observation through runtime shutdown.
Resolve library material, credentials, canonical endpoints, pool identity, Citadel connection, and host trust in one concrete app-owned module. Discovery, terminal control, and image upload now consume the same lazy root source while retaining operation-owned TOFU retries.
Server profiles now model only server and SSH identity input. Remove the unused workspace draft, profile-workspace optional branch, direct workspace save/delete APIs, and tautological tests while preserving migrated/discovered workspace IDs and recency.
Give generic SSH leases their own reusable/invalidated disposition and map the terminal facade vocabulary only inside SSHTmuxControlTransport. SSH pooling no longer imports the terminal module.
Delete the composer-only pane current-directory query, unrendered readiness/status projections, dead disconnect state, and redundant facade observation/presentation channels. Keep only the active viewport and input state consumed by MoriRemote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stack
Architecture cleanup
The branch began from the behavior-complete transplant, then removed superseded pane preview/selection capture, one-adapter modeling protocols, the one-caller screen-model facade, test fixtures from the production target, excluded composer completion plumbing, producerless tracing, unread runtime revision signaling, and manual workspace persistence paths.
The remaining deep modules own real state machines. SSH discovery, terminal control, and image upload now share one concrete app-owned authenticated-root recipe while retaining operation-owned TOFU retries.
Verification
No new TestFlight build is published without explicit approval.