Skip to content

Fixed a crash when the window is resized #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teschnei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed a crash when the window is resized #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cef/hudkit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void Hudkit::OnContextInitialized()

CefRefPtr<CefCommandLine> command_line = CefCommandLine::GetGlobalCommandLine();

HudkitRenderHandler* renderHandler = new HudkitRenderHandler(hudkitWindow.drawArea);
HudkitRenderHandler* renderHandler = new HudkitRenderHandler(&hudkitWindow.drawArea);

hudkitWindow.CEFRenderHandler = renderHandler;

Expand Down Expand Up @@ -71,4 +71,4 @@ HudkitInstance* Hudkit::GetInstance(CefRefPtr<CefBrowser> browser) {
}
}
return nullptr;
}
}
8 changes: 4 additions & 4 deletions cef/render_handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
#include "render_handler.hh"

HudkitRenderHandler::HudkitRenderHandler(DrawArea draw)
HudkitRenderHandler::HudkitRenderHandler(DrawArea* draw)
: draw(draw)
{
}

void HudkitRenderHandler::GetViewRect(CefRefPtr<CefBrowser> browser, CefRect &rect)
{
rect = CefRect(0, 0, draw.width, draw.height);
rect = CefRect(0, 0, draw->width, draw->height);
}
void HudkitRenderHandler::OnPaint(CefRefPtr<CefBrowser> browser, PaintElementType type, const RectList &dirtyRects, const void *buffer, int width, int height)
{
draw.update_texture(buffer, width, height);
}
draw->update_texture(buffer, width, height);
}
6 changes: 3 additions & 3 deletions cef/render_handler.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class HudkitRenderHandler : public CefRenderHandler
{
public:
HudkitRenderHandler(DrawArea draw);
HudkitRenderHandler(DrawArea* draw);

void GetViewRect(CefRefPtr<CefBrowser> browser, CefRect &rect) override;
void OnPaint(CefRefPtr<CefBrowser> browser, PaintElementType type, const RectList &dirtyRects, const void *buffer, int width, int height) override;
Expand All @@ -19,7 +19,7 @@ private:
IMPLEMENT_REFCOUNTING(HudkitRenderHandler);

protected:
DrawArea draw;
DrawArea* draw;
};

#endif
#endif