fix: round zoom level, osm.org will floor it#324
Merged
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/324 |
Member
Author
|
for some reason I can't run the unit test, e.g. and stuff like with totals of do you have a gut feeling why @mustaphaturhan ? |
Collaborator
|
@nilsnolde that is interesting. is it failing with a reason? can you try removing node_modules and running npm install again? |
mustaphaturhan
approved these changes
Jan 30, 2026
Member
Author
|
@mustaphaturhan the output is super huge, the above is a small example. there's many reasons why individual tests fail. I reinstalled already, didn't change. turns out it was the node version, system has node v25.2.1, when I install 22.x it runs smoothly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
fixes #322 (not really, but since osm.org won't change their url parsing, this is as close as we get)
👨💻 Changes proposed
osm.org floors any incoming zoom float, this PR rounds it to the nearest integer first.