fix: access* and bike_network bitmask#327
Merged
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/327 |
Member
Author
|
FWIW, we don't have to wait for the service to be updated before we can merge |
mustaphaturhan
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👨💻 Changes proposed
We recently changed the attributes for valhalla's /tile endpoint and only return single
access:fwd/bwduints now, which need to be decoded bcs they represent a bitmask.Also
bike_networkis (soon) a bit mask, I changed that as well.Lastly, this makes the labels bold in the popup, which seems a bit nicer to look at.
📄 Note to reviewers
access*was converted to a boolean..)📷 Screenshots
master (with FOSSGIS service)
branch (with FOSSGIS service)
branch (with fixed valhalla branch)