fix(ci): publish-charts Helm repo names and empty repo update#32
Open
mhjacks wants to merge 1 commit into
Open
fix(ci): publish-charts Helm repo names and empty repo update#32mhjacks wants to merge 1 commit into
mhjacks wants to merge 1 commit into
Conversation
Derive stable repo names without slashes, merge Chart.lock URLs, drop || true on helm repo add, and skip helm repo update when no repos exist. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-chartsderived Helm repo names from HTTP URLs by stripping the scheme, producing values likestakater.github.io/stakater-charts. Helm rejects/in repo names, so everyhelm repo addfailed. Failures were hidden with|| true, thenhelm repo updateran with zero repos and failed withno repositories found.Chart.yamlwas scanned, so charts using@aliasinChart.yamlwith resolvedhttps://…URLs inChart.locknever registered a repo.Changes
repositoryvalues from Chart.yaml and Chart.lock.ext-+ first 16 hex chars of SHA256 of the URL) and--force-update, without|| true.helm repo updateonly whenhelm repo list -o jsonhas at least one entry (jq length).Test plan
publish-chartsfor a chart that depends onhttps://stakater.github.io/stakater-charts(or anyhttps://host/pathindex).helm repo updatewhen appropriate, andhelm dependency buildsucceeds.Made with Cursor