-
Notifications
You must be signed in to change notification settings - Fork 20
Adding an option to ACS to use cluster CA, not self signed for ACS Central #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,13 @@ spec: | |
| port: 443 | ||
| route: | ||
| enabled: {{ .Values.central.exposure.route.enabled }} | ||
| {{- if .Values.central.exposure.route.reencrypt.enabled }} | ||
| reencrypt: | ||
| enabled: true | ||
| {{- if .Values.central.exposure.route.reencrypt.host }} | ||
| host: {{ .Values.central.exposure.route.reencrypt.host }} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If reencrypt is enabled, lets set the value to the default central hostname (unless explicitly declared)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But we have to keep the |
||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{- if .Values.central.persistence.enabled }} | ||
| persistence: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If reencrypt is enabled, lets disable the default route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I mentioned in the PR description, we have to keep the self-signed route because this is required for the communication between ACS Central and Sensors. Here is official ACS explanation:
https://access.redhat.com/solutions/7019861
and here is how it's coded:
https://github.com/stackrox/stackrox/blob/master/operator/api/v1alpha1/central_types.go#L458
The same is in the Central CRD manifest:
So if we disable
passthroughand use onlyreencrypt(with the same hostname) it would break sensor communication.