Skip to content

Set Patterns Operator config ConfigMap ownership to Pattern CR#592

Merged
openshift-merge-bot[bot] merged 5 commits into
validatedpatterns:mainfrom
sector2000:add-configmap-ownership
Apr 29, 2026
Merged

Set Patterns Operator config ConfigMap ownership to Pattern CR#592
openshift-merge-bot[bot] merged 5 commits into
validatedpatterns:mainfrom
sector2000:add-configmap-ownership

Conversation

@sector2000
Copy link
Copy Markdown
Contributor

With this PR the patterns-operator-config ConfigMap is being owned by the Pattern CR, and as a result any change to the ConfigMap triggers a reconciliation.

As a consequence, the analytics.enabled config parameter is being dropped, since it influences the controller behaviour, independently form the Pattern instance. The ANALYTICS env variable is left for the purpose.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 21, 2026

Hi @sector2000. Thanks for your PR.

I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@darkdoc
Copy link
Copy Markdown
Contributor

darkdoc commented Apr 29, 2026

/ok-to-test

@darkdoc
Copy link
Copy Markdown
Contributor

darkdoc commented Apr 29, 2026

/ok-to-test

@darkdoc
Copy link
Copy Markdown
Contributor

darkdoc commented Apr 29, 2026

/lgtm

@darkdoc
Copy link
Copy Markdown
Contributor

darkdoc commented Apr 29, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkdoc, sector2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 9942678 into validatedpatterns:main Apr 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants