Introduce Bootstrap secrets#125
Open
mhjacks wants to merge 3 commits into
Open
Conversation
mhjacks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Bootstrap" secrets are directly injected into a cluster to make the rest of the pattern work; examples include secrets necessary for using CSI drivers or secrets that ArgoCD needs to access pattern material. There has not been a clear mechanism for doing this previously.
This PR introduces a workflow that introduces a stage at the beginning of a pattern install (immediately after the creation of the pattern CR) that looks for bootstrap secrets and attempts to install them (failing if it finds them and can't).
The process looks for bootstrap secrets outside of the git repository only, using the suffix "-boostrap", so it could find and process ~/values-secret-multicloud-gitops-boostrap.yaml or ~/values-secret-boostrap.yaml, for example.
It will also be possible to install them as a separate step using the load_secrets_bootstrap.yml playbook.
This PR fixes an issue with discovering pattern settings and allows the display_secrets_info playbook to run as well.
A followup PR will add appropriate targets to Makefile-common.