fix: include bool dtype in categorical columns for TabularDescriptionTables (ZD #609)#496
Merged
fix: include bool dtype in categorical columns for TabularDescriptionTables (ZD #609)#496
Conversation
Contributor
PR SummaryThis pull request extends the functionality of the TabularDescriptionTables module by modifying the way categorical columns are identified. Previously, only columns with data types 'object' and 'category' were included. The change introduces boolean (bool) columns as part of the categorical data types, ensuring better representation of datasets that include flag-like or binary data. Additionally, a unit test has been added in the tests suite to verify that boolean columns (such as 'flag' and 'active' in the example) are appropriately identified and appear in the categorical table. This ensures that function behavior aligns with the intended inclusion of boolean types in categorical analyses. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
TabularDescriptionTables.pyclassifies columns by pandas dtype viaselect_dtypes(). The three helpers coverint/float/uint8(numerical),object/category(categorical), anddatetime, butboolis absent absent. A column withdtype=boolfalls through every check and is never included.How to test
Supply a bool dataframe to the dataset.
What needs special review?
None
Dependencies, breaking changes, and deployment notes
None
Release notes
booldata fields in categorical table resultsChecklist