Add include_blank option to enum field#21
Open
duduribeiro wants to merge 1 commit intovaliot:masterfrom
Open
Conversation
Currently the field only renders the blank option if there is no presence validator on the specific field. But there is a problem with this approach because you can have the validator field but with some condition like: validates :matrimonial_regime, presence: true, if: :married? and the field was being rendered without the blank option. This commit adds a new `include_blank` that can be set into enum field to force a blank field to be present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the field only renders the blank option if there is no presence validator on the specific field. But there is a problem with this approach because you can have the validator field but with some condition like:
validates :matrimonial_regime, presence: true, if: :married?
and the field was being rendered without the blank option.
This commit adds a new
include_blankthat can be set into enum field to force a blank field to be present.My second thought was to do something like:
but I thought that
include_blankwas a better option for persons that wants to add the blank option event if its being validated.