Skip to content

introduce derive_eq option#20

Draft
valsteen wants to merge 1 commit into
mainfrom
derive_eq
Draft

introduce derive_eq option#20
valsteen wants to merge 1 commit into
mainfrom
derive_eq

Conversation

@valsteen

@valsteen valsteen commented Aug 7, 2023

Copy link
Copy Markdown
Owner

TODO

  • test
  • doc

questions:

  • derive_hash option ?
  • separately mark fields for hash and eq ? - #[sort_by] becomes a wildcard, introduce top-level and per-field #[hash], #[eq] , #[partial_eq], #[ord], #[partial_ord]

@jayvdb

jayvdb commented Nov 19, 2023

Copy link
Copy Markdown

ping @valsteen , will you be able to finish this?

@valsteen

valsteen commented Nov 19, 2023

Copy link
Copy Markdown
Owner Author

@jayvdb hey thanks for giving interest in this project ! I'm getting lost in other non-programming side-projects but here is the struggle I faced when starting this: for consistency, I think all of Eq, PartialEq, Ord, PartialOrd and Hash should have such opt-out option ; but the syntax I started with seems to be a dead end, I feel like I have to break compatibility. Or introduce a guesswork in the parsing so the old ( current ) way still works. Any fresh idea welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants