Skip to content

Opensearch for document queries + generic case search - #810

Merged
marijnritense merged 51 commits into
feature/open-searchfrom
poc/opensearch-for-document-queries
Jul 21, 2026
Merged

Opensearch for document queries + generic case search#810
marijnritense merged 51 commits into
feature/open-searchfrom
poc/opensearch-for-document-queries

Conversation

@marijnritense

Copy link
Copy Markdown
Collaborator

No description provided.

marijnritense and others added 30 commits March 31, 2026 11:19
# Conflicts:
#	backend/building-block/src/main/kotlin/com/ritense/buildingblock/configuration/BuildingBlockAutoConfiguration.kt
#	backend/building-block/src/main/kotlin/com/ritense/buildingblock/security/config/BuildingBlockHttpSecurityConfigurer.kt
#	backend/building-block/src/main/kotlin/com/ritense/buildingblock/service/BuildingBlockFormFlowDefinitionService.kt
#	backend/building-block/src/main/kotlin/com/ritense/buildingblock/web/rest/BuildingBlockFormFlowManagementResource.kt
#	backend/building-block/src/test/kotlin/com/ritense/buildingblock/web/rest/BuildingBlockFormFlowManagementResourceIT.kt
#	backend/core/src/main/resources/config/liquibase/13-22-0/13-22-0-master.xml
#	backend/form-flow/src/main/kotlin/com/ritense/formflow/common/ValtimoFormFlow.kt
#	backend/form-flow/src/main/kotlin/com/ritense/formflow/repository/FormFlowDefinitionRepository.kt
#	backend/form-flow/src/main/kotlin/com/ritense/formflow/service/FormFlowService.kt
#	backend/form-flow/src/main/kotlin/com/ritense/formflow/web/rest/FormFlowManagementResource.kt
#	backend/importer/src/main/kotlin/com/ritense/importer/ValtimoImportTypes.kt
#	frontend/projects/valtimo/case/src/lib/components/case-list/case-list.component.html
#	frontend/projects/valtimo/case/src/lib/components/case-list/case-list.component.ts
#	frontend/projects/valtimo/case/src/lib/services/case-list-search.service.ts
#	gradle.properties
swapped over to spring events for keeping opensearch in sync
… help with using global search, and being able to global search more fields.
* Opensearch re-indexing

* Reconcile missing index updates
# Conflicts:
#	backend/apps/dev/build.gradle
- added generic case list global search support (still work in progress, currently does not respect access control)
- lots of tiny fixes
…ensearch-for-document-queries

# Conflicts:
#	frontend/projects/valtimo/shared/src/lib/models/menu-item.model.ts
#	frontend/projects/valtimo/shared/src/lib/services/menu-include.service.ts
#	gradle.properties
implemented a (work in progress) expanded row template
… when a run is finished) + more UI improvements
@marijnritense
marijnritense requested a review from a team as a code owner July 16, 2026 14:26
@marijnritense

Copy link
Copy Markdown
Collaborator Author
  • If I open the “Start reindex” modal, fill in the fields, and close it without saving, then reopen the modal, the “Modified after” field is still populated with the previously filled date. The form should be reset when the modal is closed without saving

    • When the “Start reindex” modal is opened, the “Start reindex” button is already enabled. It should remain disabled until all required fields have been completed

    • Date fields such as “Modified after” and “Started/Finished” use a different date format from the rest of the application

    • It is possible to submit the form with the default “All definitions” option selected. However, after expanding the accordion, the “Document definition” field is displayed as empty '-'

Should all be done now! We discussed the date fields separately, and the format is actually consistent.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
frontend/projects/valtimo/admin-settings/src/lib/components/start-reindex-modal/start-reindex-modal.component.html (1)

51-53: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Disable Start reindex while the form is invalid.

The submit button is always enabled, so users can trigger reindexing before required fields are completed. Bind its disabled state to the reactive form validity.

Proposed fix
-    <button cdsButton="primary" (click)="onSubmit()">
+    <button cdsButton="primary" [disabled]="formGroup.invalid" (click)="onSubmit()">

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 97bf5f2b-18aa-4c0a-9683-b3afec779ad5

📥 Commits

Reviewing files that changed from the base of the PR and between dee1946 and fab0808.

📒 Files selected for processing (36)
  • backend/apps/dev/src/main/resources/config/application.yml
  • backend/apps/dev/src/main/resources/logback-spring.xml
  • backend/apps/evenementenvergunning/src/main/resources/config/application.yml
  • backend/apps/evenementenvergunning/src/main/resources/logback-spring.xml
  • backend/apps/gzac/src/main/resources/config/application.yml
  • backend/apps/gzac/src/main/resources/logback-spring.xml
  • backend/apps/valtimo/src/main/resources/config/application.yml
  • backend/apps/valtimo/src/main/resources/logback-spring.xml
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/authorization/mapper/JsonSchemaDocumentCaseDefinitionOpenSearchMapper.kt
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/autoconfigure/DocumentOpenSearchAutoConfiguration.kt
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/handler/DocumentOpenSearchEventListener.kt
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/service/DelegatingDocumentSearchService.kt
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/service/DocumentOpenSearchIndexInitializer.kt
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/web/SearchEngineResource.kt
  • backend/case/src/main/java/com/ritense/document/domain/impl/JsonSchemaDocument.java
  • backend/contract/src/main/java/com/ritense/valtimo/contract/database/PostgresQueryDialectHelper.java
  • backend/core/src/main/resources/config/liquibase/13-38-0/13-38-0-master.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260630-create-reindex-run-table.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260701-add-changed-on-to-json-schema-document.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260701-create-pending-index-deletion-table.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260701-create-reconcile-state-table.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260710-add-reindex-run-pruned-count.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260713-add-reindex-run-total-count.xml
  • backend/core/src/main/resources/config/liquibase/13-38-0/20260713-backfill-modified-on.xml
  • backend/core/src/main/resources/config/liquibase/changelog-master.xml
  • backend/core/src/main/resources/config/liquibase/initial-setup/initial-setup-master.xml
  • backend/dependencies/valtimo-dependencies/build.gradle
  • frontend/apps/evenementenvergunning/src/environments/environment.ts
  • frontend/apps/valtimo/src/environments/environment.ts
  • frontend/projects/valtimo/admin-settings/src/lib/components/admin-settings-opensearch/admin-settings-opensearch.component.ts
  • frontend/projects/valtimo/admin-settings/src/lib/components/start-reindex-modal/start-reindex-modal.component.html
  • frontend/projects/valtimo/admin-settings/src/lib/components/start-reindex-modal/start-reindex-modal.component.ts
  • frontend/projects/valtimo/components/src/lib/components/carbon-list/carbon-list.component.scss
  • frontend/projects/valtimo/components/src/lib/components/carbon-list/carbon-list.component.ts
  • frontend/projects/valtimo/shared/assets/core/en.json
  • frontend/projects/valtimo/shared/assets/core/nl.json
💤 Files with no reviewable changes (1)
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/authorization/mapper/JsonSchemaDocumentCaseDefinitionOpenSearchMapper.kt
🚧 Files skipped from review as they are similar to previous changes (10)
  • backend/core/src/main/resources/config/liquibase/changelog-master.xml
  • frontend/projects/valtimo/components/src/lib/components/carbon-list/carbon-list.component.scss
  • frontend/projects/valtimo/shared/assets/core/nl.json
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/service/DelegatingDocumentSearchService.kt
  • frontend/projects/valtimo/shared/assets/core/en.json
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/handler/DocumentOpenSearchEventListener.kt
  • backend/case-opensearch/src/main/kotlin/com/ritense/document/opensearch/autoconfigure/DocumentOpenSearchAutoConfiguration.kt
  • frontend/projects/valtimo/admin-settings/src/lib/components/admin-settings-opensearch/admin-settings-opensearch.component.ts
  • frontend/projects/valtimo/components/src/lib/components/carbon-list/carbon-list.component.ts
  • frontend/projects/valtimo/admin-settings/src/lib/components/start-reindex-modal/start-reindex-modal.component.ts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e172d09d-d0ea-430e-80db-c542c7de3142

📥 Commits

Reviewing files that changed from the base of the PR and between bce4230 and 2fd68d5.

📒 Files selected for processing (6)
  • documentation/SUMMARY.md
  • documentation/fundamentals/getting-started/compatibility-matrix.md
  • documentation/fundamentals/getting-started/modules/core/case-opensearch.md
  • documentation/release-notes/13.x.x/13.38.0/README.md
  • documentation/running-valtimo/application-configuration/feature-toggles.md
  • documentation/running-valtimo/application-configuration/opensearch.md

Comment thread documentation/release-notes/13.x.x/13.38.0/README.md Outdated
Comment thread backend/apps/dev/build.gradle
Comment thread backend/apps/gzac/src/main/resources/config/application.yml Outdated
@marijnritense
marijnritense merged commit 45843fe into feature/open-search Jul 21, 2026
186 checks passed
@marijnritense
marijnritense deleted the poc/opensearch-for-document-queries branch July 21, 2026 08:07
@github-actions github-actions Bot deleted a comment from valtimo-platform Bot Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test env Create a remote test environment for this PR in the Ritense product development cluster tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants