Added manifeset file to exports - #845
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughExports now generate 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 57586104-fd4b-4ffb-845f-46319863cb11
📒 Files selected for processing (27)
backend/building-block/src/main/kotlin/com/ritense/buildingblock/service/BuildingBlockDefinitionExporter.ktbackend/building-block/src/main/kotlin/com/ritense/buildingblock/service/BuildingBlockProcessLinkExporter.ktbackend/building-block/src/test/kotlin/com/ritense/buildingblock/service/BuildingBlockProcessLinkImporterTest.ktbackend/case/src/main/kotlin/com/ritense/case/service/CaseDefinitionExporter.ktbackend/case/src/test/kotlin/com/ritense/case/service/CaseDefinitionExportManifestIntTest.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/ExportResult.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/ValtimoExportService.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/config/ExportAutoConfiguration.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/ArtifactDependency.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/ArtifactManifestEntry.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/ArtifactType.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/DependencyType.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/ExportManifest.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/ResolvableValue.ktbackend/exporter/src/main/kotlin/com/ritense/exporter/manifest/ValtimoVersionResolver.ktbackend/exporter/src/test/kotlin/com/ritense/exporter/ExportServiceIntTest.ktbackend/exporter/src/test/kotlin/com/ritense/exporter/TestArtifactExportRequest.ktbackend/exporter/src/test/kotlin/com/ritense/exporter/TestArtifactExporter.ktbackend/exporter/src/test/kotlin/com/ritense/exporter/ValtimoExportServiceTest.ktbackend/exporter/src/test/kotlin/com/ritense/exporter/manifest/ResolvableValueSerializerTest.ktbackend/plugin-valtimo/build.gradlebackend/plugin-valtimo/src/main/kotlin/com/ritense/valtimo/processlink/ProcessLinkAutoConfiguration.ktbackend/plugin-valtimo/src/main/kotlin/com/ritense/valtimo/processlink/mapper/PluginProcessLinkMapper.ktbackend/plugin-valtimo/src/test/kotlin/com/ritense/valtimo/processlink/mapper/PluginProcessLinkMapperTest.ktbackend/process-link/src/main/kotlin/com/ritense/processlink/exporter/ProcessLinkExporter.ktbackend/process-link/src/main/kotlin/com/ritense/processlink/mapper/ProcessLinkMapper.ktdocumentation/release-notes/13.x.x/13.39.0/README.md
| isRoot = true, | ||
| ).toMutableSet() | ||
|
|
||
| createManifestFile(artifacts, dependencies)?.let { exportList.add(it) } |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Reserve the manifest filename before adding it.
ExportFile deduplicates by path, so an exporter-provided valtimo-manifest.json silently wins and the generated index is discarded. Replace an existing entry at that path, or reject the collision.
Proposed fix
- createManifestFile(artifacts, dependencies)?.let { exportList.add(it) }
+ createManifestFile(artifacts, dependencies)?.let { manifest ->
+ exportList.removeAll { it.path == manifest.path }
+ exportList.add(manifest)
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| createManifestFile(artifacts, dependencies)?.let { exportList.add(it) } | |
| createManifestFile(artifacts, dependencies)?.let { manifest -> | |
| exportList.removeAll { it.path == manifest.path } | |
| exportList.add(manifest) | |
| } |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Clean boot everything, when I try to export bezwaar case def (latest) through UI I get: jakarta.servlet.ServletException: Handler dispatch failed: java.lang.NoSuchMethodError: 'void com.ritense.exporter.ExportResult.(java.util.Set, java.util.Set, int, kotlin.jvm.internal.DefaultConstructorMarker)' |
2 participants
Fixes: generiekzaakafhandelcomponent/gzac-issues#786