improvements#15
Open
vanadgir wants to merge 5 commits into
Open
Conversation
clean up roll result calculation separate sfx and bgm listeners add gravity control
roll detect improvement again stop bgm autoplay, show "loading" text
bake dice numbers into shared canvas textures batch resolution state updates split contexts to stop cross-die re-renders prevent misreading cocked dice as 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate sfx and bgm listeners
add gravity control
stop bgm autoplay, show "loading" text
bake dice numbers into shared canvas textures
batch resolution state updates
split contexts to stop cross-die re-renders
prevent misreading cocked dice as 1