Glyph: do not error on invalid starting points#177
Merged
Conversation
This makes it easier to use these types idiomatically.
This updates our glyph outline processing logic so that it just simply skips invalid starting points (a point on a new contour that is not on-curve, or an end point that is a first point) rather than error out. These points appear to be present in some glyphs in DejaVu Sans (particularly in the successive end point form, in the form of two points being marked as end points a row). I'm not too sure if there are cases where these would ever be correct, but I'm currently working under the assumption that they are not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175
This updates our glyph outline processing logic so that it just simply skips invalid starting points (a point on a new contour that is not on-curve, or an end point that is a first point) rather than error out.
These points appear to be present in some glyphs in DejaVu Sans (particularly in the successive end point form, in the form of two points being marked as end points a row). I'm not too sure if there are cases where these would ever be correct, but I'm currently working under the assumption that they are not.