Another attempt to get revoluteJoint#106
Closed
rafirstfruit wants to merge 10 commits intovanderlin:masterfrom
Closed
Another attempt to get revoluteJoint#106rafirstfruit wants to merge 10 commits intovanderlin:masterfrom
rafirstfruit wants to merge 10 commits intovanderlin:masterfrom
Conversation
This is one of those changes that anger people, and it pretty much nullifies the chances of this fork of ever being merge back upstream. But those whitespaces were driving me (and my editor) insanse, I couldn't bear it.
Author
|
Sorry, had to use this branch for work. I'll try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that 50% of the forks of your project add revolute joints.
I did too, and I tried to copy your style as much as possible. Do you think this can be merged?
Oh, and like #101, I also noticed the
jointTypemember, and also went for separate class - it's just cleaner this way.