Skip to content

Fix poorly structured navbar#922

Open
manavi-24 wants to merge 3 commits into
vanshchauhan21:mainfrom
manavi-24:manavi2
Open

Fix poorly structured navbar#922
manavi-24 wants to merge 3 commits into
vanshchauhan21:mainfrom
manavi-24:manavi2

Conversation

@manavi-24

Copy link
Copy Markdown
Contributor

Issue Title

Please enter the title of the issue related to your pull request.
Enter the issue title here-

FRONTEND ISSUE: Fix Poorly Structured Navbar

  • I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
Describe the aim of the project-

The goal is to ensure the navigation bar is visually clean, well-structured, and user-friendly by correcting misalignments, uneven spacing, and inconsistent visual hierarchy.

  • I have described the aim of the project.

Name

Please mention your name.
Enter your name here-

Manavi

  • I have provided my name.

GitHub ID

Please mention your GitHub ID.
Enter your GitHub ID here-

manavi-24

  • I have provided my GitHub ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, Hactoberfest).
Enter your participant role here-

SSOC

  • I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
Closes: #issue-number

Closes: #920

  • I have provided the issue number.

Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.
Describe your changes here-

  • Refactored the navbar's flex structure for improved alignment and symmetry.
  • Adjusted spacing, padding, and margins between navbar elements to ensure evenness.
  • Ensured consistent visual grouping and hierarchy of logo, navigation links, and buttons.
  • Made the navbar responsive and visually balanced across desktop and mobile devices.
  • Cleaned up redundant or conflicting styles affecting navbar layout.
  • I have described my changes.

Type of Change

Select the type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how your changes have been tested.
Describe your testing process here.

  • Visually inspected the navbar on Chrome and Firefox on desktop.
  • Used browser DevTools to verify correct alignment, spacing, and responsiveness at various screen widths.
  • Checked that elements remain properly grouped and spaced on both desktop and mobile views.
  • Ensured there are no console errors or layout shifts.
  • I have described my testing process.

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.

@vercel

vercel Bot commented Jun 16, 2025

Copy link
Copy Markdown

@manavi-24 is attempting to deploy a commit to the vanshchauhan21's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Bhavishya2601

Copy link
Copy Markdown
Contributor

Pls resolve conflicts

@Bhavishya2601

Copy link
Copy Markdown
Contributor

Provide screenshots/video of your work before and after the changes

@Bhavishya2601 Bhavishya2601 requested a review from Copilot June 17, 2025 14:56

This comment was marked as outdated.

@manavi-24

Copy link
Copy Markdown
Contributor Author

Provide screenshots/video of your work before and after the changes

Provide screenshots/video of your work before and after the changes

image
Screenshot 2025-06-18 010033
image
This is after I made the changes

@Bhavishya2601 Bhavishya2601 requested a review from Copilot June 19, 2025 04:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The purpose of this PR is to fix the poorly structured navbar by refactoring the drawer component to improve layout and theme toggling.

  • Renames and refactors the component from "Navbar" to "AppDrawer" to accept external open state.
  • Replaces local dark mode state and functions with a context-based theme toggle.
  • Removes unused imports and redundant code for a cleaner, responsive design.

Comment thread src/components/Common/Header/drawer.js
Comment thread src/components/Common/Header/drawer.js
@Bhavishya2601

Copy link
Copy Markdown
Contributor

Pls resolve conflicts

@manavi-24

Copy link
Copy Markdown
Contributor Author

on web I am seeing coflicts too complex to e resolved in oline editors and on vs code i see no conflicts

@manavi-24

Copy link
Copy Markdown
Contributor Author

plz help me out

@Bhavishya2601

Copy link
Copy Markdown
Contributor

Then you can close this PR and open a new one

@manavi-24 manavi-24 closed this Jun 19, 2025
@manavi-24 manavi-24 reopened this Jun 19, 2025
@manavi-24

Copy link
Copy Markdown
Contributor Author

Hi!! It's unfair to me because my PR wasn't merged on time. I had created a PR back then when there were fewer conflicts. Now the whole website structure has changed which has lead to even greater and newer conflicts. All my efforts have gone in vain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FRONTEND ISSUE: Fix Poorly Structured Navbar

3 participants