fix: Make News section text readable in dark mode#923
Merged
vanshchauhan21 merged 1 commit intoJun 17, 2025
Conversation
|
@Abhishek-singh88 is attempting to deploy a commit to the vanshchauhan21's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎉🎉 Thank you for your contribution! Your PR #923 has been merged! 🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Title
[Frontend issue] Unreadable text in News section during dark mode
Info about the Related Issue
What's the goal of the project?
To create a responsive and visually accessible crypto tracking application that works seamlessly across light and dark themes.
Name
Abhishek Singh
GitHub ID
@Abhishek-singh88
Identify Yourself
SSOC S4 Participant
Closes
Closes: #919
Describe the Add-ons or Changes You've Made
Fixed the issue where the News section text (“Sorry, No Items In The News.”) was unreadable in dark mode.
Added Tailwind’s dark:text-white utility to ensure text remains visible on dark backgrounds.
Also removed 3 extra closing braces from
src/components/Feedback/Feedbacksection.cssthat were causing a build failure, though unrelated to the main issue.Type of Change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
I ran the development server locally and:
Switched to dark mode
Navigated to the News section
Confirmed the previously invisible text is now clearly readable
Checklist
My code follows the guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly wherever it was hard to understand.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added things that prove my fix is effective or that my feature works.