fix: ShellCheck CI split + health_check.sh crash fixes#96
Merged
Conversation
|
VantisOS Team seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
CI Changes: - Split ShellCheck into errors (blocking, --severity=error) and warnings (advisory, --severity=warning with continue-on-error) - Ensures real errors fail CI while warnings are visible but non-blocking Health Check Fixes: - Fix grep pipe crash with set -euo pipefail in check_ci_integrity (first grep returning exit 1 when no matches propagated via pipefail) - Fix arithmetic crash: (( count++ )) returns 1 when count=0 under set -e Replaced with count=$((count + 1)) - Fix unbound variable: declare -a arrays empty under set -u Replaced with explicit ARRAY=() initialization - Improve inflated version regex to exclude URLs and descriptive text - Exclude ci.yml from continue-on-error check (advisory steps are OK) Script Linting: - create_boot_animation.sh: quote variable in printf (SC2046) - bootstrap.sh: double-quote $@ in 4 places (SC2068 errors) - bootstrap.sh: add shellcheck source=/dev/null directive (SC1090) CHANGELOG: - Reword inflated version description to avoid false positive detection
b45be82 to
eacc857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all remaining CI failures in the Vantis CI and Health Check workflows.
CI Changes
--severity=error— real errors fail the build--severity=warningwithcontinue-on-error: true— visible but non-blockingHealth Check Fixes (3 separate crash bugs)
check_ci_integrity): Firstgrepreturning exit 1 when no matches found propagated throughpipefail, killing the script. Fixed with|| truewrapping.check_scripts):(( count++ ))returns exit 1 when count=0 underset -e. Replaced withcount=$((count + 1)).print_summary):declare -aarrays empty underset -u. Fixed with explicitARRAY=()initialization.ci.yml(advisory steps are intentional).Script Linting
create_boot_animation.sh: Quote variable in printf (SC2046)bootstrap.sh: Double-quote$@in 4 places (SC2068 errors), add shellcheck directive (SC1090)CHANGELOG
Testing