Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses #182 and adds support for conditional attribute extension, by giving the user the choice of a
.replacingor.combiningoperation, while the modifier defaults to.replacing.Data types, which cannot meaningfully combined like
Boolwill automatically replaced. Open for debate, whether aStringshould count as a combinable type. For now, it is more about list attributes such asclass,headers... I would say.This pull request acknowledges that the value of the attributes like
class,headersare actually a list, defined by its individual values plus a separator. With that in place, all information needed for a predictable combination is already available.