Fix Failing Tests, Address Client Connection Issue#155
Fix Failing Tests, Address Client Connection Issue#155jhoughjr wants to merge 8 commits intovapor:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 6 6
Lines 659 659
=======================================
Hits 546 546
Misses 113 113 🚀 New features to boost your workflow:
|
|
The semantics of |
|
We really shouldn't be touching BoringSSL anymore |
Yeah, but that's out of scope for this PR. |
|
Ill check these tests and update. |
… reliable and consistant across platforms.
…st what is consistently behaved across platforms.
|
Im beginning to think there is no way to resolve this issue with this test. The behavior is not consistent enough across swift versions and platforms. The utility of the test is unknown to me also. I don't know how to even do it (much less elegantly), to handle URL initialization across versions and platforms. |
Updated from swift-tools-version:5.7 to 5.9.
This fixes an issue where clients would get a bad Sec-WebSocket-Accept value from vapor.
Fixed bad url tests on WebSocket, Async and regular.
There is an issue for covering all bad urls that the WebSocket might reject as URL seems to init fragments such as bare escape sequences. I'm not sure yet how that could be covered better, or how important it is.