Conversation
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.2 | |||
| // swift-tools-version:5.3 | |||
There was a problem hiding this comment.
We can't change the tools version as we need to keep support for 5.2 - does that block the PR?
There was a problem hiding this comment.
I believe 5.3 is require for the
condition: .when(
platforms: [Platform.iOS, Platform.macOS, Platform.tvOS, Platform.watchOS]
)
If this is a blocker then i might look into how i could make changes to this package so that an additional package could provide the NIOTransportServices decency. (either through a subclass or a plugin like solution). what do you think would be the best approach?
There was a problem hiding this comment.
Add a Package@swift-5.2.swift manifest which contains the old version and then that should work (we might need to wrap the new methods in a Swift version check as well)
There was a problem hiding this comment.
ok i will give that a go, should i also update the GitHub workflow so that it includes both versions of swift?
There was a problem hiding this comment.
@gwynne could you update the CI with all the new fun stuff?
|
@0xTim I added the checks and package file for 5.2 i think the version checks i did are also in the correct places. (i did think that this might fail if for some reason someone has a package called |
|
@hishnash I think |
|
@0xTim cool are there any other changes i need to make. |
Add NIOTransportServices support on Apple platforms.
On apple platforms it is best to use the
NIOTSEventLoopGroupand use the corresponding SSL configurations.This PR also adds a
HTTPChannelIntercepterthat can be used to inspect the HTTP handshake requests (for locking etc).