feat: doctor panel — runtime + MCP health checks#89
Open
varkart wants to merge 3 commits into
Open
Conversation
- get_shell_path() spawns login shell to resolve full PATH (fixes 'npx not found' false positives in GUI apps that inherit minimal PATH) - doctor::report() returns structured DoctorSection/DoctorItem for UI - Checks: shell PATH dirs, 7 runtime binaries (node/npx/python3/uv/docker/ bun/deno), each active MCP command, npm packages (non -y/--yes) - run_doctor IPC command (async, re-detects tools fresh) - DoctorView: idle/running/done states, green/warn/error icons, expandable fix hints per item, issue count badge - Settings: Doctor entry in Developer section navigates to DoctorView - Background check() updated to use shell PATH too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_shell_path()spawns a login shell ($SHELL -l -c 'echo $PATH') to get the full user PATH. macOS GUI apps inherit a minimal PATH (/usr/bin:/bin:...) sonpx,node,brewetc. were falsely reported as missing. Background notification checks now use this too.doctor::report()returns a structuredVec<DoctorSection>withDoctorItem(id, label, status, detail, fixHint) — serialized to the frontend via newrun_doctorIPC commandnode,npx,python3,uv,docker,bun,deno-y/--yesnpx MCPs)Test plan
npxand-yflag should show OK (auto-download, not flagged as missing)npx not foundfalse positive should be gone on machines with nvm/homebrew node