refactor(config): remove duplicate loadConfig to establish single sou… - #9
Merged
varneeth01 merged 1 commit intoAug 5, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the config package by removing the duplicate loadConfig implementation from the schema module, leaving the loader module as the single source of truth for config loading behavior.
Changes:
- Removed the
loadConfigfunction previously defined inpackages/config/src/schema.ts. - Reduced schema module responsibilities to schema/types/utilities and defaults, relying on
packages/config/src/loader.tsfor config loading.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
609
to
610
| // ============================================ | ||
| // Connection String Helpers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rce of truth