Support common http_content config option#205
Open
elliterate wants to merge 1 commit into
Open
Conversation
elliterate
commented
May 23, 2026
Comment on lines
+52
to
+58
| func (s *StepHTTPServer) Handler(config *CommonConfig) http.Handler { | ||
| if config.HTTPDir != "" { | ||
| return http.FileServer(http.Dir(config.HTTPDir)) | ||
| } | ||
|
|
||
| return commonsteps.MapServer(config.HTTPContent) | ||
| } |
Author
There was a problem hiding this comment.
As this type largely appears to be a fork of packer-plugin-sdk's StepHTTPServer type, I opted to approximately mirror that package's Handler() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
packer-plugin-sdksupports anhttp_contentconfig option that allows one to specify the served file contents inline rather than specify a directory on the local filesystem. This allows one to easily use HCL expressions and functions, such astemplatefile, to dynamically generate the served files.Addresses #49 and #180.