fix: update PIN collection and storage method #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vcwild
commented
Nov 13, 2025
vcwild
commented
- Added a new function to collect a user-defined PIN interactively.
- Implemented silent truncation of PINs longer than 30 characters.
- Updated the keyring storage to include the collected PIN alongside the OTP secret.
- Introduced a method to create a PIN without enforcing 4-digit validation.
Owner
Author
|
Edit: Added @jhklarcher as co-author for finding the bug on Debian distributions. |
- Added a new function to collect a user-defined PIN interactively. - Implemented silent truncation of PINs longer than 30 characters. - Updated the keyring storage to include the collected PIN alongside the OTP secret. - Introduced a method to create a PIN without enforcing 4-digit validation. Co-authored-by: José Henrique Kleinübing Larcher <jhklarcher@users.noreply.github.com>
vcwild
force-pushed
the
fix-pin-setup
branch
from
630648b to
e42e400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.