Skip to content

Backport PR #3448 to release/v1.7 for Migrate from bincode to wincode#3471

Merged
kmrmt merged 1 commit intorelease/v1.7from
backport/release/v1.7/feature/rust/migration-from-bincode-to-wincode
Mar 4, 2026
Merged

Backport PR #3448 to release/v1.7 for Migrate from bincode to wincode#3471
kmrmt merged 1 commit intorelease/v1.7from
backport/release/v1.7/feature/rust/migration-from-bincode-to-wincode

Conversation

@vdaas-ci
Copy link
Copy Markdown
Collaborator

Description

  • we need to migrate from bincode because it is deprecated
  • I check the performance implementing benchmark and decided to use wincode

Related Issue

Versions

  • Vald Version: v1.7.17
  • Go Version: v1.25.5
  • Rust Version: v1.92.0
  • Docker Version: v29.1.3
  • Kubernetes Version: v1.34.3
  • Helm Version: v4.0.4
  • NGT Version: v2.5.0
  • Faiss Version: v1.13.1

Checklist

Special notes for your reviewer

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated default serialization codec across the key-value store and queue libraries for improved performance and reliability.
    • Added new error types to queue error handling to provide better diagnostics for encoding, decoding, UUID parsing, and text encoding issues.
    • Minor formatting adjustments to build configuration files.

* wincode migration

* 🤖 Update license headers / Format go codes and yaml files

Signed-off-by: Vdaas CI <vald@vdaas.org>

* fix

* resolve conflict

* 🤖 Update license headers / Format go codes and yaml files

Signed-off-by: Vdaas CI <vald@vdaas.org>

---------

Signed-off-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: Vdaas CI <vald@vdaas.org>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Feb 10, 2026

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0090474
Status: ✅  Deploy successful!
Preview URL: https://586ab02f.vald.pages.dev
Branch Preview URL: https://backport-release-v1-7-featur-xwyf.vald.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/release/v1.7/feature/rust/migration-from-bincode-to-wincode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vdaas-ci
Copy link
Copy Markdown
Collaborator Author

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/v1.7@e57f08f). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/v1.7   #3471   +/-   ##
==============================================
  Coverage                ?   1.37%           
==============================================
  Files                   ?      56           
  Lines                   ?    4140           
  Branches                ?       0           
==============================================
  Hits                    ?      57           
  Misses                  ?    4055           
  Partials                ?      28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmrmt kmrmt merged commit 8452ad1 into release/v1.7 Mar 4, 2026
251 of 258 checks passed
@kmrmt kmrmt deleted the backport/release/v1.7/feature/rust/migration-from-bincode-to-wincode branch March 4, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants