Tooling: declare rustfmt + clippy as required toolchain components#22
Merged
Conversation
Pinning `apps/desktop/rust-toolchain.toml` to a specific channel without a `components` line tells rustup to install only the minimal profile (rustc + cargo + rust-std). CI scripts then invoke `cargo fmt --check` and `cargo clippy` and trip on missing components — every Rust job on a fresh runner has been failing at the rustfmt step since the channel pin landed. Add `components = ["rustfmt", "clippy"]` so the runner installs them automatically alongside the pinned channel. Devs with local rustup configs that already include rustfmt are unaffected (rustup honours the declaration whether the components are already present or not).
The `rust` paths-filter only watched `apps/desktop/src-tauri/**`, so edits to `apps/desktop/rust-toolchain.toml` skipped the Rust CI jobs entirely. The toolchain file shapes every Rust build on every runner; not running the Rust suite when it changes is exactly backwards. Add the toolchain file to the rust filter so PRs that touch it actually exercise the jobs they affect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning
apps/desktop/rust-toolchain.tomlto a specific channel without acomponentsline tells rustup to install only the minimal profile (rustc + cargo + rust-std). Every Rust CI job since the pin landed (commit `7d771ca8`) fails at the rustfmt step because rustfmt isn't installed.Blocks #18 and #21 from going CI-green; should land first.
Test plan