feat(vector): Include log format support#528
feat(vector): Include log format support#528lazam wants to merge 2 commits intovectordotdev:developfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ead59f9a6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| - name: VECTOR_LOG | ||
| value: "{{ .Values.logLevel | default "info" }}" | ||
| value: "{{ .Values.logConfig.level | default "info" }}" |
There was a problem hiding this comment.
Reading VECTOR_LOG only from .Values.logConfig.level causes existing installations that still set logLevel in their override files to silently fall back to info after upgrade, because Helm keeps old keys but this template no longer consumes them. That changes runtime log verbosity unexpectedly in production; this should keep a compatibility fallback to logLevel (or explicitly fail with a migration error) instead of ignoring prior user configuration.
Useful? React with 👍 / 👎.
|
I regenerated the docs, @pront . Thanks! |
2 participants
The chart currently only supports
log levelwhich means that it needs to change thelog formatvia env vars instead of the same manner as level. This PR supports the change in log format via this chart. The only challenge is that it is a breaking change due to the naming convention. I thought to uselogFormatto have it backwards compatibile but it is beneficial to have them under a single mapping/section.