Skip to content

feat: add apiVersion override for workloads#529

Merged
pront merged 2 commits intovectordotdev:developfrom
medzin:develop
Apr 6, 2026
Merged

feat: add apiVersion override for workloads#529
pront merged 2 commits intovectordotdev:developfrom
medzin:develop

Conversation

@medzin
Copy link
Copy Markdown
Contributor

@medzin medzin commented Jan 26, 2026

Allow overriding apiVersion for DaemonSet and StatefulSet via daemonSet.apiVersion and statefulSet.apiVersion values.

Enables using custom controllers (e.g., OpenKruise Advanced DaemonSet/StatefulSet) without maintaining a chart fork.

@medzin medzin mentioned this pull request Jan 27, 2026
Open
@pront
Copy link
Copy Markdown
Member

pront commented Apr 3, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 3, 2026

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pront
pront approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @medzin

@pront pront enabled auto-merge (squash) April 3, 2026 18:12
auto-merge was automatically disabled April 6, 2026 17:08

Head branch was pushed to by a user without write access

medzin added 2 commits April 6, 2026 19:16
@medzin
feat: add apiVersion override for workloads
9209fb2 
Allow overriding apiVersion for DaemonSet and StatefulSet via
daemonSet.apiVersion and statefulSet.apiVersion values.

Enables using custom controllers (e.g., OpenKruise Advanced
DaemonSet/StatefulSet) without maintaining a chart fork.
@medzin
fix: add missing helm docs
3564643
@medzin
Copy link
Copy Markdown
Contributor Author

medzin commented Apr 6, 2026

@pront fixed linter erros and rebased the branch.

@pront
Copy link
Copy Markdown
Member

pront commented Apr 6, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 6, 2026

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pront pront enabled auto-merge (squash) April 6, 2026 19:53
@pront pront merged commit 17899f2 into vectordotdev:develop Apr 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pront pront pront approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@medzin @pront