fix(vector): set haproxy terminationGracePeriodSeconds on pod spec#539
Merged
pront merged 3 commits intovectordotdev:developfrom Apr 8, 2026
Merged
fix(vector): set haproxy terminationGracePeriodSeconds on pod spec#539pront merged 3 commits intovectordotdev:developfrom
pront merged 3 commits intovectordotdev:developfrom
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
auto-merge was automatically disabled
April 7, 2026 05:28
Head branch was pushed to by a user without write access
pront
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes HAProxy Deployment rendering in the vector chart so
haproxy.terminationGracePeriodSecondsis applied to the Pod spec.Previously,
haproxy.terminationGracePeriodSecondsonly affected hard-stop-after in haproxy.cfg, but was not reflected in the Pod spec.This change makes chart behavior consistent with the value’s intent and documentation.